Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update flag so that keyboards starts with an upper case letter #1177

Merged
merged 3 commits into from
Feb 19, 2022

Conversation

epicadk
Copy link
Contributor

@epicadk epicadk commented Feb 17, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1176

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
The other options are we CAP_WORDS and CAP_CHARACTERS.

I think we can have CAP_WORDS for singleline and CAP_SENTENCES for Multiline : /.

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read the Contributing page
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1177 (11a8c65) into master (fa51f69) will increase coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1177      +/-   ##
============================================
+ Coverage     84.58%   84.59%   +0.01%     
- Complexity      626      627       +1     
============================================
  Files           135      135              
  Lines         10347    10354       +7     
  Branches        767      766       -1     
============================================
+ Hits           8752     8759       +7     
- Misses         1212     1213       +1     
+ Partials        383      382       -1     
Impacted Files Coverage Δ
...droid/fhir/db/impl/entities/PositionIndexEntity.kt 0.00% <0.00%> (ø)
...le/android/fhir/db/impl/entities/UriIndexEntity.kt 0.00% <0.00%> (ø)
...com/google/android/fhir/db/impl/dao/ResourceDao.kt 83.18% <85.71%> (+0.61%) ⬆️
...estionnaireItemEditTextStringViewHolderDelegate.kt 88.88% <100.00%> (+3.17%) ⬆️
...e/android/fhir/db/impl/entities/DateIndexEntity.kt 100.00% <100.00%> (ø)
...droid/fhir/db/impl/entities/DateTimeIndexEntity.kt 100.00% <100.00%> (ø)
...android/fhir/db/impl/entities/NumberIndexEntity.kt 100.00% <100.00%> (ø)
...droid/fhir/db/impl/entities/QuantityIndexEntity.kt 100.00% <100.00%> (ø)
...roid/fhir/db/impl/entities/ReferenceIndexEntity.kt 100.00% <100.00%> (ø)
...le/android/fhir/db/impl/entities/ResourceEntity.kt 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b5e41...11a8c65. Read the comment docs.

@epicadk
Copy link
Contributor Author

epicadk commented Feb 19, 2022

@jingtang10 sorry forgot to or the input class

@epicadk epicadk merged commit abb6c64 into master Feb 19, 2022
@epicadk epicadk deleted the ak/capitalize branch February 19, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Data Capture - soft keyboard should start with an upper case character for 'string' widgets
2 participants