Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localizing last contacted date #1161

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Localizing last contacted date #1161

merged 2 commits into from
Feb 11, 2022

Conversation

vvikramraj
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1144

Description
Localizing last contacted date

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Bug fix

Screenshots (if applicable)
Before fix: See #1144
After fix: 4fkfcQGF5BJtWaF

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read the Contributing page
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #1161 (ff629a5) into master (bb2dd1f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1161   +/-   ##
=========================================
  Coverage     84.54%   84.54%           
  Complexity      614      614           
=========================================
  Files           135      135           
  Lines         10299    10299           
  Branches        763      763           
=========================================
  Hits           8707     8707           
  Misses         1212     1212           
  Partials        380      380           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efcdabb...ff629a5. Read the comment docs.

@jingtang10 jingtang10 enabled auto-merge (squash) February 10, 2022 12:28
@jingtang10 jingtang10 merged commit 8b4b8e1 into master Feb 11, 2022
@jingtang10 jingtang10 deleted the vr/date-format branch February 11, 2022 10:17
ktarasenko pushed a commit that referenced this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Last Contacted" Date is not being localized.
2 participants