Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip build directories before uploading #1157

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Zip build directories before uploading #1157

merged 2 commits into from
Feb 9, 2022

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Feb 9, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Zip build directories before uploading

This reduces the total uploading time from ~40m to ~5m.

Alternative(s) considered
NA

Type
Choose one: Builds

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read the Contributing page
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #1157 (71e3aee) into master (e2a8d0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1157   +/-   ##
=========================================
  Coverage     84.51%   84.51%           
  Complexity      608      608           
=========================================
  Files           134      134           
  Lines         10276    10276           
  Branches        756      756           
=========================================
  Hits           8685     8685           
  Misses         1215     1215           
  Partials        376      376           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a8d0a...71e3aee. Read the comment docs.

@jingtang10 jingtang10 enabled auto-merge (squash) February 9, 2022 13:45
Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Hopefully our CI builds will be much faster now :)

@jingtang10 jingtang10 merged commit 06107c2 into master Feb 9, 2022
@jingtang10 jingtang10 deleted the jt/ci-zip branch February 9, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants