Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog, update component and layout icons #1101

Merged
merged 5 commits into from
Feb 9, 2022
Merged

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1047

Description
Clear and concise code change description.
As per ux guideline, it is required to update new icons which are shown on landing page.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read the Contributing page
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #1101 (dfa09c5) into master (c13b477) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1101   +/-   ##
=========================================
  Coverage     84.51%   84.51%           
  Complexity      608      608           
=========================================
  Files           134      134           
  Lines         10276    10276           
  Branches        756      756           
=========================================
  Hits           8685     8685           
  Misses         1215     1215           
  Partials        376      376           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13b477...dfa09c5. Read the comment docs.

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add screenshots

@santosh-pingle
Copy link
Collaborator Author

Screen Shot 2022-02-04 at 10 55 18 AM

@jingtang10
Copy link
Collaborator

i can't really see the difference of the icons @shelaghm @santosh-pingle is this a redesign?

@jingtang10 jingtang10 enabled auto-merge (squash) February 4, 2022 11:29
@jingtang10 jingtang10 merged commit e2a8d0a into master Feb 9, 2022
@jingtang10 jingtang10 deleted the sp/1047-icons branch February 9, 2022 13:40
ktarasenko pushed a commit that referenced this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Catalog, update component icons with shadows.
2 participants