Catalog, show questionnaire response when submit questionnaire button get clicked. #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Show Bottom navigation bar with Components and Layouts menus. 2. Implements components screen. 3. Implements layouts screen. 4. Handles bottom navigation clicks. 5. Update actionbar.
We can also see screenshots in issue #1081
|
|
can you put the submit button as a menu item in the app bar? |
|
looking into the comment. |
done. |
santosh-pingle
requested review from
joiskash,
ktarasenko and
vvikramraj
as code owners
|
Submit menu added to overflow menu until #1088 get fixed.
|
jingtang10
approved these changes
Feb 18, 2022
jingtang10
requested changes
Feb 18, 2022
catalog/src/main/java/com/google/android/fhir/catalog/DemoQuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
jingtang10
reviewed
Feb 18, 2022
catalog/src/main/java/com/google/android/fhir/catalog/DemoQuestionnaireFragment.kt
Outdated
Show resolved
Hide resolved
|
looking into the review comments. |
jingtang10
requested changes
Feb 22, 2022
catalog/src/main/java/com/google/android/fhir/catalog/DemoQuestionnaireFragment.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1081
Description
Collect questionnaire response json string.
Design and implement fragment to show questionnaire json output string
Navigate back to landing page on close button click.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project./gradlew checkand./gradlew connectedCheckto test my changes locally