-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload local changed resources using Bundle transaction #1084
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
============================================
- Coverage 84.57% 84.53% -0.05%
- Complexity 632 646 +14
============================================
Files 135 140 +5
Lines 10407 10488 +81
Branches 787 795 +8
============================================
+ Hits 8802 8866 +64
- Misses 1209 1223 +14
- Partials 396 399 +3
Continue to review full report at Codecov.
|
450504d
to
ef49423
Compare
demo/src/main/java/com/google/android/fhir/demo/api/HapiFhirService.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/bundle/BundlePayloadGenerator.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/bundle/BundlePayloadGenerator.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/bundle/BundlePayloadGenerator.kt
Outdated
Show resolved
Hide resolved
demo/src/main/java/com/google/android/fhir/demo/data/HapiFhirResourceDataSource.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/impl/FhirEngineImpl.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/google/android/fhir/sync/bundle/HttpVerbBasedBundleEntryComponentGenerator.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/google/android/fhir/sync/bundle/HttpVerbBasedBundleEntryComponentGenerator.kt
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/bundle/TransactionBundleGenerator.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/bundle/TransactionBundleGenerator.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like the abstraction of the generator much better - thanks @aditya-07 🙏
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1021
Description
Instead of making individual CRUD request for each local change, we would Bundle multiple resources inside a Bundle Transaction.
This PR also mandates for now that all the resources are created on server using Http PUT instead of POST.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project./gradlew check
and./gradlew connectedCheck
to test my changes locally