Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Patient registration page, City and Country made mandatory #1074

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

PallaviGanorkar
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #842

Description
On Patient registration page, City and Country made mandatory

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read How to Contribute
  • I have read the Developer's guide
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@PallaviGanorkar PallaviGanorkar added the type:bug Something isn't working label Jan 21, 2022
@PallaviGanorkar PallaviGanorkar added this to In progress in Demo applications via automation Jan 21, 2022
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #1074 (f45586b) into master (9c786ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1074   +/-   ##
=========================================
  Coverage     84.46%   84.46%           
  Complexity      608      608           
=========================================
  Files           133      133           
  Lines         10282    10282           
  Branches        753      753           
=========================================
  Hits           8685     8685           
  Misses         1222     1222           
  Partials        375      375           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c786ff...f45586b. Read the comment docs.

@jingtang10
Copy link
Collaborator

Congrats on your first PR! @PallaviGanorkar

@Tarun-Bhardwaj
Copy link

@PallaviGanorkar , great to see your first PR getting approved. Looking forward to getting the changes merged once you are back.

@Tarun-Bhardwaj Tarun-Bhardwaj changed the title [842] On Patient registration page, City and Country made mandatory On Patient registration page, City and Country made mandatory Jan 29, 2022
@PallaviGanorkar PallaviGanorkar enabled auto-merge (squash) January 31, 2022 11:45
@PallaviGanorkar PallaviGanorkar merged commit 8fc9edc into master Jan 31, 2022
Demo applications automation moved this from In progress to Done Jan 31, 2022
@PallaviGanorkar PallaviGanorkar deleted the 842-RegPatientCityCountryMandatory branch January 31, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Archived in project
3 participants