Catalog, datepicker component workflow. #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Show Bottom navigation bar with Components and Layouts menus. 2. Implements components screen. 3. Implements layouts screen. 4. Handles bottom navigation clicks. 5. Update actionbar.
santosh-pingle
changed the title
santosh-pingle
requested review from
aditya-07,
deepankarb,
jingtang10,
kevinmost,
stevenckngaa and
yigit
as code owners
jingtang10
approved these changes
Jan 31, 2022
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
============================================
- Coverage 84.52% 84.51% -0.01%
Complexity 608 608
============================================
Files 134 134
Lines 10279 10276 -3
Branches 756 756
============================================
- Hits 8688 8685 -3
Misses 1215 1215
Partials 376 376
Continue to review full report at Codecov.
|
8 tasks
ktarasenko
pushed a commit
that referenced
this pull request
Feb 16, 2022
* Sdc gallery app landing page 1. Show Bottom navigation bar with Components and Layouts menus. 2. Implements components screen. 3. Implements layouts screen. 4. Handles bottom navigation clicks. 5. Update actionbar. * Rename file name. * Update components and layouts vector icons. * Sdc gallery app single choice workflow. * Update it as boolean choice. * Address review comments. * Boolean choice component icon. * Spotless apply * Build failures * Delete gallery drawables. * fix package name in nav graph * Spotless apply. * Delete gallery color resource * theme attributes for color value. * bottom view margin * Datepicker component workflow. Co-authored-by: Jing Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1045
Description
Clear and concise code change description.
Design date picker questionnaire json.
Write api to fetch date picker questionnaire json file name.
Apply custom style at application side.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project./gradlew checkand./gradlew connectedCheckto test my changes locally