Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with Data safety section #1036

Closed
wants to merge 1 commit into from

Conversation

juanchazo
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes b/200620733

Description
A data safety section was added to the readme as external documentation informing users that this SDK does not collect or share any personal or sensitive user data.

Type
Documentation

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read How to Contribute
  • I have read the Developer's guide
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@juanchazo juanchazo added the type:documentation Improvements or additions to documentation label Jan 13, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #1036 (235316f) into master (0691f75) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1036   +/-   ##
=========================================
  Coverage     84.39%   84.39%           
  Complexity      598      598           
=========================================
  Files           133      133           
  Lines         10284    10284           
  Branches        753      753           
=========================================
  Hits           8679     8679           
  Misses         1221     1221           
  Partials        384      384           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0691f75...235316f. Read the comment docs.

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @juanchazo!

I wonder if we should include this information as part of the wiki page in each library. For example, the FHIR Engine wiki already includes a security section: https://github.com/google/android-fhir/wiki/FHIR-Engine-Library#privacy--security where this declaration can be a little more detailed and tailored to each library?

@jingtang10
Copy link
Collaborator

jingtang10 commented Jan 13, 2022

@fredhersch @jtournier23 fyi

@juanchazo
Copy link
Contributor Author

Changes made to the wiki instead of readme, closing PR.

@juanchazo juanchazo closed this Jan 24, 2022
@jingtang10 jingtang10 deleted the jp/update-data-safety-readme branch April 16, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants