Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdc gallery app, multiple choice (check boxes) component workflow #1016

Merged
merged 32 commits into from
Jan 28, 2022

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1011

Description
Design multiple choice questionnaire json.
Write api to fetch multi choice questionnaire json file name.
Apply custom style at application side.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read How to Contribute
  • I have read the Developer's guide
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@santosh-pingle santosh-pingle changed the title Sp/1011 multichoice Sdc gallery app, multiple choice (check boxes) component workflow Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #1016 (ffe9558) into master (324af6d) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1016   +/-   ##
=========================================
  Coverage     84.46%   84.47%           
  Complexity      608      608           
=========================================
  Files           133      133           
  Lines         10282    10282           
  Branches        753      753           
=========================================
+ Hits           8685     8686    +1     
+ Misses         1222     1221    -1     
  Partials        375      375           
Impacted Files Coverage Δ
...va/com/google/android/fhir/db/impl/DatabaseImpl.kt 90.12% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324af6d...ffe9558. Read the comment docs.

@santosh-pingle santosh-pingle marked this pull request as ready for review January 11, 2022 05:30
@santosh-pingle
Copy link
Collaborator Author

Screen Shot 2022-01-13 at 9 29 06 PM

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @santosh-pingle!

@santosh-pingle santosh-pingle enabled auto-merge (squash) January 28, 2022 11:25
@santosh-pingle santosh-pingle merged commit 119f5a3 into master Jan 28, 2022
@santosh-pingle santosh-pingle deleted the sp/1011-multichoice branch January 28, 2022 12:49
ktarasenko pushed a commit that referenced this pull request Feb 16, 2022
)

* Sdc gallery app landing page
1. Show Bottom navigation bar with Components and Layouts menus.
2. Implements components screen.
3. Implements layouts screen.
4. Handles bottom navigation clicks.
5. Update actionbar.

* Rename file name.

* Update components and layouts vector icons.

* Sdc gallery app single choice workflow.

* Update it as boolean choice.

* Address review comments.

* Boolean choice component icon.

* Spotless apply

* Build failures

* Delete gallery drawables.

* fix package name in nav graph

* Spotless apply.

* Delete gallery color resource

* theme attributes for color value.

* bottom view margin

* Multi choice workflow and custom style

* Address review comments

* Address review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Catalog app, multiple choice (check boxes) component workflow
2 participants