Localized date rendering #1013
Merged
Localized date rendering #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvikramraj
requested review from
aditya-07,
deepankarb,
jingtang10,
joiskash,
kevinmost,
stevenckngaa and
yigit
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1013 +/- ##
============================================
+ Coverage 84.49% 84.51% +0.01%
Complexity 608 608
============================================
Files 133 134 +1
Lines 10277 10275 -2
Branches 753 756 +3
============================================
Hits 8684 8684
+ Misses 1218 1215 -3
- Partials 375 376 +1
Continue to review full report at Codecov.
|
jingtang10
requested changes
Jan 17, 2022
There was a problem hiding this comment.
Thanks @vvikramraj! Great job writing your first PR in the repo :)
Left a few comments - also, can you please think about handing this for the date time picker? Either same PR or create a follow up PR/issue.
...droid/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactoryInstrumentedTest.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Show resolved
Hide resolved
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
demo/src/main/java/com/google/android/fhir/demo/PatientDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Jan 25, 2022
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Feb 1, 2022
There was a problem hiding this comment.
Looks good @vvikramraj - just one comment to update the import.
| get() { | ||
| val date = Date.from(atStartOfDay(ZoneId.systemDefault())?.toInstant()) | ||
| return if (isAndroidIcuSupported()) | ||
| DateFormat.getDateInstance(DateFormat.DEFAULT).format(date) |
There was a problem hiding this comment.
this should be android.icu.text.DateFormat and not java.text.DateFormat
https://developer.android.com/guide/topics/resources/internationalization
ktarasenko
pushed a commit
that referenced
this pull request
Feb 16, 2022
* Localized date rendering * Addressing code review comments * Switching between DateFormat and SimpleDateFormat based on SDK version * Fixes from running spotless check and apply * Fixing imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #898
Description
Change to display dates in a locale-specific
DateFormat.DEFAULTformat.Alternative(s) considered
NA
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project./gradlew checkand./gradlew connectedCheckto test my changes locally