Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Show/hide error state" setting to clearer UI, e.g. toggle #1635

Closed
williamito opened this issue Sep 27, 2022 · 4 comments · Fixed by #2563
Closed

Change "Show/hide error state" setting to clearer UI, e.g. toggle #1635

williamito opened this issue Sep 27, 2022 · 4 comments · Fixed by #2563
Labels
effort:xsmall Extra small effort - 1 day good first issue Good for newcomers P3 Low priority issue

Comments

@williamito
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It's not super clear whether show error state is turned on or off in the current UI. Given it has 2 states, using a toggle would be less ambiguous.

Describe the solution you'd like
Change UI from a button with changing text to an on/off toggle.

Describe alternatives you've considered
Any other unambiguous ui would work, e.g. dropdown.

Would you like to work on the issue?
Not sure on difficulty, but if someone can point me to the code I can take an initial look?
@shelaghm
Copy link

Could we use a checkbox? Sometimes toggles are also confusing if they are on or off.
Screenshot below.
Screen Shot 2022-09-29 at 14 47 06

@rajeshvelicheti
Copy link

fragment_model_bottom_sheet.xml

@Tarun-Bhardwaj Tarun-Bhardwaj added P3 Low priority issue effort:small Small effort - 2 days labels Oct 18, 2022
@jingtang10 jingtang10 added effort:xsmall Extra small effort - 1 day good first issue Good for newcomers and removed effort:small Small effort - 2 days labels Jan 30, 2024
@kartikeysaran
Copy link

Hi,
I'd love to contribute by working on this issue. If no one is currently working on it, would it be alright for me to take a shot at it? It seems like a good first issue to get started with.

@chungwwei chungwwei mentioned this issue Jun 4, 2024
Merged
7 tasks
@jingtang10
Copy link
Collaborator

suggest we lose the x button to be more aligned with https://m3.material.io/components/bottom-sheets/overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort:xsmall Extra small effort - 1 day good first issue Good for newcomers P3 Low priority issue
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use checkbox for show/hide error state chungwwei/android-fhir
6 participants
@rajeshvelicheti @williamito @jingtang10 @kartikeysaran @Tarun-Bhardwaj @shelaghm