Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use checkbox for show/hide error state #2563

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Conversation

chungwwei
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1635

Description
Remove the button that toggles show/hide error state
Use checkbox for show/hide error state in modal bottom sheet

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Other

Screenshots (if applicable)
Screenshot_20240604_162536

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this change @chungwwei

looking at https://m3.material.io/components/bottom-sheets/overview i don't think we want to keep the x button at the top left corner of the bottom sheet - it appears superfuluous. can you please removew? thanks!

also - can you screenrecord a short video to show this works?

@chungwwei
Copy link
Contributor Author

short_demo.webm

@chungwwei chungwwei requested a review from jingtang10 June 6, 2024 15:46
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this! Great job!

@jingtang10 jingtang10 merged commit 735fd0f into google:master Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Change "Show/hide error state" setting to clearer UI, e.g. toggle
3 participants