cleaned up old state for dropdown (#1779)

* cleaned up Old State for dropdown * testcase added
google · Jan 5, 2023 · 87c69f6 · 87c69f6
1 parent 0ec9496
commit 87c69f6
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/.../android/fhir/datacapture/views/QuestionnaireItemDropDownViewHolderFactoryEspressoTest.kt b/.../android/fhir/datacapture/views/QuestionnaireItemDropDownViewHolderFactoryEspressoTest.kt
@@ -99,6 +99,31 @@ class QuestionnaireItemDropDownViewHolderFactoryEspressoTest {
  assertThat((answerHolder!!.single().value as Coding).display).isEqualTo("Coding 3")
  }
 
+ @Test
+ fun shouldClearAutoCompleteTextViewOnRebindingView() {
+ var answerHolder: List<QuestionnaireResponse.QuestionnaireResponseItemAnswerComponent>? = null
+ val questionnaireItemViewItem =
+ QuestionnaireItemViewItem(
+ answerOptions("Coding 1", "Coding 2", "Coding 3", "Coding 4", "Coding 5"),
+ responseOptions(),
+ validationResult = NotValidated,
+ answersChangedCallback = { _, _, answers -> answerHolder = answers },
+ )
+ runOnUI { viewHolder.bind(questionnaireItemViewItem) }
+
+ onView(withId(R.id.auto_complete)).perform(showDropDown())
+ onView(withText("Coding 3"))
+ .inRoot(isPlatformPopup())
+ .check(matches(isDisplayed()))
+ .perform(click())
+ assertThat(viewHolder.itemView.findViewById<TextView>(R.id.auto_complete).text.toString())
+ .isEqualTo("Coding 3")
+
+ runOnUI { viewHolder.bind(questionnaireItemViewItem) }
+ assertThat(viewHolder.itemView.findViewById<TextView>(R.id.auto_complete).text.toString())
+ .isEqualTo("")
+ }
+
  @Test
  fun shouldSetDropDownValueStringToAutoCompleteTextView() {
  var answerHolder: List<QuestionnaireResponse.QuestionnaireResponseItemAnswerComponent>? = null

diff --git a/...a/com/google/android/fhir/datacapture/views/QuestionnaireItemDropDownViewHolderFactory.kt b/...a/com/google/android/fhir/datacapture/views/QuestionnaireItemDropDownViewHolderFactory.kt
@@ -103,6 +103,7 @@ internal object QuestionnaireItemDropDownViewHolderFactory :
 
  private fun cleanupOldState() {
  autoCompleteTextView.setAdapter(null)
+ autoCompleteTextView.text = null
  }
  }
 }