Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse TFRF for continuous SmoothStreaming segments refresh #7005

Open
wants to merge 1 commit into
base: dev-v2
Choose a base branch
from

Conversation

phhusson
Copy link
Contributor

@phhusson phhusson commented Feb 21, 2020

This fixes issues #855

This is needed in our use-case because we have a backend for which the access to the manifest requires a token that is valid only for one minute.

I have tested this with http:https://essdrmproducts-dev.insidesecure.com:9090/live/clear.isml/manifest
I added logs in HttpDataSource to log every access to manifest and confirmed it is now only accessed once, while it was recurrent before.

Points that are unclear to me:

  • When testing on http:https://essdrmproducts-dev.insidesecure.com:9090/live/clear.isml/manifest I can see that Exoplayer tries to download chunks ahead of their time, so the server returns few 412 before the chunks are actually available. This doesn't happen prior to the patch. Since I don't change the chunk download algorithm I'm not sure why this happen.
  • I'm using System.currentTimeMillis() to expire old chunks. I think this is the sane way to do, but i'm not totally convinced

@guidofranceschini
Copy link

Hi phhusson ,
I am not among the contributors, but I can probably explain why you observe a few 412.
Within a manifest you can get information only about chunks that are fully available.
Instead. from the boxes within a chunk you can determine the timestamp and hence the URL of the next chunk, but this "next chunk" is not necessarily available yet. You have probably updated the code in a way that it now knows about the "next chunk" before it is actually available.

@ojw28 ojw28 assigned tonihei and unassigned ojw28 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants