Merge 1.0.13 to master #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cache ref didn't work because it referred to a private variable (which isn't documented) from a public interface definition (which is). Meaning the Javadoc generator was trying to link to documentation that didn't exist.
- Bring back requirement for the first video frame to be rendered before isReady returns true, *unless* we've deduced that the upstream source is serving multiple renderers. - Ditto for requiring that the audio track has some buffered data.
Since we have a Format class as well, it's very confusing that FormatHolder actually holds a MediaFormat. I think it's quite likely that Format will need promoting into the root package as part of the HLS work, which will make this even more confusing (although it is possible that for HLS we'll define yet another Format class, if it turns out we need significantly different fields). Note - I deliberately avoided renaming the formatHolder args/params, because they're not particularly ambiguous and because it introduces some ugly line breaks.
…z atom to parse. Issue: #35
It looks like for the case of self-contained media segments, it's possible to get stuck without failure in the case that the load fails having loaded less than the length of the init data.
This means that after a decoder flush, the renderer will avoid feeding non-keyframes into the decoder until it has received and fed the first keyframe. The decoder has no way of correctly decoding non-keyframes that arrive before a keyframe.
- Skips unrecognized elements rather than crashing. - FourCC treated as required for video and optional elsewhere, as per the SmoothStreaming spec. - Only parse initData text when we're actually in the ProtectionHeader element
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge 1.0.13 to master