Subsequent `selectTracks() after prepare does not override position #11285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MaskingMediaPeriod.onChildSourceInfoRefreshed() already has the position correct from
the initial timeline update, since the `preparePositionUs` is 0 the second condition in the
if:
```
if (preparePositionOverrideUs != C.TIME_UNSET && positionUs == preparePositionUs) {
...
```
is false, so the `preparePositionUs` is not reset. This causes it to be used incorrectly
on subsequent `selectTracks()` calls where `positionUs` does match `preparePositionUs`
The fix simply resets the `preparePositionOverrideUs` unconditionally, as only the
initial `selectTracks()` after the prepared transition should use the override
|
Hi Steve - can you please make this PR against the https://github.com/androidx/media project instead? Unfortunately we're unable to merge PRs in this deprecated project. After the change is merged in that project it will get pushed back to the dev-v2 branch here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MaskingMediaPeriod.onChildSourceInfoRefreshed() already has the position correct from the initial timeline update, since the
preparePositionUsis 0 the second condition in the if:is false, so the
preparePositionUsis not reset. This causes it to be used incorrectly on subsequentselectTracks()calls wherepositionUsdoes matchpreparePositionUsThe fix simply resets the
preparePositionOverrideUsunconditionally, as only the initialselectTracks()after the prepared transition should use the override