Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AdsResponse #3548

Closed
Gobi1989 opened this issue Dec 5, 2017 · 0 comments
Closed

Support AdsResponse #3548

Gobi1989 opened this issue Dec 5, 2017 · 0 comments
Assignees
@andrewlewis
Labels
enhancement

Comments

@Gobi1989
Copy link

Gobi1989 commented Dec 5, 2017

Hi All,

In my project we are using Exoplayer for content video and ima extension for Ads. From our backend we are receiving AdsResponse (xml values). As the IMA SDK supports only Ads URI, i have altered the IMA SDK so that it will accept AdsResponse as input params.

I have made some changed in ImaAdsLoader.java which will accept AdsReponse as input. I have aatched the file for your reference.

By default IMA SDK supports AdsReposne by any other means?

ImaAdsLoader.zip
@andrewlewis andrewlewis self-assigned this Dec 5, 2017
@andrewlewis andrewlewis mentioned this issue Dec 8, 2017
Closed
ojw28 pushed a commit that referenced this issue Dec 12, 2017
@andrewlewis @ojw28
Add Builder for ImaAdsLoader and allow early requestAds
e2bba15 
Also fix propagation of ad errors that occur when no player
is attached.

Issue: #3548
Issue: #3556

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=178767997
@ojw28 ojw28 closed this as completed Dec 12, 2017
ojw28 pushed a commit that referenced this issue Dec 12, 2017
@andrewlewis @ojw28
Add Builder for ImaAdsLoader and allow early requestAds
b223988 
Also fix propagation of ad errors that occur when no player
is attached.

Issue: #3548
Issue: #3556

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=178767997
@google google locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewlewis andrewlewis

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewlewis @Gobi1989 @ojw28