Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in DVB subtitle handler #2957

Closed
goffioul opened this issue Jun 15, 2017 · 2 comments
Closed

Crash in DVB subtitle handler #2957

goffioul opened this issue Jun 15, 2017 · 2 comments
Assignees
@ojw28
Labels
bug

Comments

@goffioul
Copy link
Contributor

ExoPlayer version: 2.4.1
Sample stream: https://drive.google.com/open?id=0BwljeX6541LubXprdmEtTFdBT00
Steps to reproduce:

  • start playback with plain HTTP
  • enable a subtitle track

Backtrace:

FATAL EXCEPTION: Thread-4
Process: com.google.android.exoplayer2.demo, PID: 24109
java.lang.ArrayIndexOutOfBoundsException: length=4; index=36
	at com.google.android.exoplayer2.text.dvb.DvbParser.paint8BitPixelCodeString(DvbParser.java:789)
	at com.google.android.exoplayer2.text.dvb.DvbParser.paintPixelDataSubBlock(DvbParser.java:638)
	at com.google.android.exoplayer2.text.dvb.DvbParser.paintPixelDataSubBlocks(DvbParser.java:592)
	at com.google.android.exoplayer2.text.dvb.DvbParser.decode(DvbParser.java:187)
	at com.google.android.exoplayer2.text.dvb.DvbDecoder.decode(DvbDecoder.java:47)
	at com.google.android.exoplayer2.text.dvb.DvbDecoder.decode(DvbDecoder.java:25)
	at com.google.android.exoplayer2.text.SimpleSubtitleDecoder.decode(SimpleSubtitleDecoder.java:70)
	at com.google.android.exoplayer2.text.SimpleSubtitleDecoder.decode(SimpleSubtitleDecoder.java:25)
	at com.google.android.exoplayer2.decoder.SimpleDecoder.decode(SimpleDecoder.java:222)
	at com.google.android.exoplayer2.decoder.SimpleDecoder.run(SimpleDecoder.java:188)
	at com.google.android.exoplayer2.decoder.SimpleDecoder.access$000(SimpleDecoder.java:25)
	at com.google.android.exoplayer2.decoder.SimpleDecoder$1.run(SimpleDecoder.java:66)
@ojw28 ojw28 added the bug label Jun 15, 2017
@ojw28 ojw28 self-assigned this Jun 28, 2017
@ojw28
Copy link
Contributor

ojw28 commented Jun 29, 2017

There's a small issue in the DVB parser. I'll push a fix shortly. Brilliantly, there's also a small bug in the DVB spec itself, which corresponds to half of the issue :)!

ojw28 added a commit that referenced this issue Jun 30, 2017
@ojw28
Fix DvbParser bug
04b57f9 
Issue: #2957

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=160628086
@ojw28 ojw28 closed this as completed Jun 30, 2017
ojw28 added a commit that referenced this issue Jun 30, 2017
@ojw28
Fix DvbParser bug
a579b8d 
Issue: #2957

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=160628086
@goffioul
Copy link
Contributor Author

Verified in branch dev-v2. Subtitles now working fine. Thanks.

@google google locked and limited conversation to collaborators Oct 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ojw28 ojw28

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goffioul @ojw28