Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conditional probability function #30

Merged
merged 6 commits into from
Jan 26, 2021

Conversation

Sohl-Dickstein
Copy link
Contributor

  • Rename conditional_prob_fn to cond_log_prob_fn.
  • Add keyword to determine whether probabilities are normalized to sum to 1 over targets, or whether probabilities are absolute. Normalizing to 1 over targets allows a broader class of models to return conditional log probabilities, including energy based models, and human evaluation.
  • Edit a bunch of doc strings.

@Sohl-Dickstein Sohl-Dickstein marked this pull request as ready for review January 26, 2021 05:23
@Sohl-Dickstein Sohl-Dickstein merged commit eb64516 into main Jan 26, 2021
@Sohl-Dickstein Sohl-Dickstein deleted the update-conditional_prob_fn branch January 26, 2021 05:56
Sohl-Dickstein added a commit that referenced this pull request Jun 29, 2021
Update conditional probability function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants