Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in time convention application #169

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

peter-dudbridge
Copy link

I noticed when passing in a forecast using the lead_time naming convention that the valid_time mapping didn't appear to occur. On closer inspection I think I found a bug where this mapping only occurs if prediction_timedelta is used, presumably this is a bug given you remap it to lead_time :)

Copy link

google-cla bot commented Jul 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant