Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #45:out of range bug #46

Merged
merged 1 commit into from
May 21, 2024

Conversation

WWWonderer
Copy link
Contributor

See issue #45.

Copy link

google-cla bot commented May 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Author:    Shuo Zhang <[email protected]>
Date:      Mon May 20 00:25:05 2024 -0400
Committer: Shuo Zhang <[email protected]>
@carlini
Copy link
Collaborator

carlini commented May 20, 2024

Your explanation and fix make sense to me. But I've been bitten enough times by "looks correct"....

Let me run a test on one of my ~10TB datasets just to make sure I get the same results before and after to make sure though. This shouldn't take too long, I'll post and update here when it finishes.

@WWWonderer
Copy link
Contributor Author

Hi Nicholas, ok thank you!

@carlini carlini merged commit 4e9888a into google-research:master May 21, 2024
1 check passed
@carlini
Copy link
Collaborator

carlini commented May 21, 2024

I've confirmed this doesn't change results on my test case. Thanks, merged!

@WWWonderer
Copy link
Contributor Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants