-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LlamaIndex and Gemini Quickstart #7
base: main
Are you sure you want to change the base?
Conversation
Manually confirmed CLA. All good there. |
Hi @MarkDaoust Thank you for the confirmation. The review hasn't been reviewed to merge |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need images that are clearly open-licensed. We can't merge it with these images.
Sure, understood, will modify it |
4f6aab7
to
49d8f8b
Compare
Few changes to note:
Used Open Licenses images from Unsplash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete the ".DS_Store" file.
For external integrations we're going to start an /examples/integrations directory. Can you create the directory and move this from /quickstarts/ to examples/integrations?
Thanks.
9561292
to
74ddf11
Compare
Done |
Hey @lucifertrj - sorry it's taken a while to get to this. Thanks for the contribution. Can you give us a bit of context as to what this guide is trying to achieve? Right now it's missing some key introductory text to explain to the user what they are going to learn & do. For my context, and for the guide, can you give it a high level description, like "How to use Llama Index with the Gemini API for multi-turn chat conversations" or whatever task you want cover. Before we review the content in detail it'd be great to make sure that this doesn't duplicate any existing content, and has some value on its own, so this info will help. |
Hey @markmcd sure. Will document the notebook |
This PR contains a notebook: where anyone can get started with LlamaIndex with Gemini as the LLM.