Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_alphafold_test #168

Closed
player1321 opened this issue Sep 10, 2021 · 3 comments
Closed

run_alphafold_test #168

player1321 opened this issue Sep 10, 2021 · 3 comments

Comments

@player1321
Copy link

Hi,

I tried to run run_alphafold_test.py, and I think the line79-82, i.e.,
self.assertSequenceEqual(
['features.pkl', 'msas', 'ranked_0.pdb', 'ranking_debug.json',
'relaxed_model1.pdb', 'result_model1.pkl', 'timings.json',
'unrelaxed_model1.pdb'], target_output_files)

should be
self.assertSequenceEqual(
sorted(['features.pkl', 'msas', 'ranked_0.pdb', 'ranking_debug.json',
'relaxed_model1.pdb', 'result_model1.pkl', 'timings.json',
'unrelaxed_model1.pdb']), sorted(target_output_files))
@Augustin-Zidek
Copy link
Collaborator

Thanks for reporting this. I will push a fix shortly (the easiest fix is to change AssertSequenceEqual to AssertCountEqual).

Augustin-Zidek added a commit that referenced this issue Sep 10, 2021
@Augustin-Zidek @copybara-github
Accept any ordering given by ListDir in the assert.
1d43aaf 
Addresses #168.

PiperOrigin-RevId: 395907797
Change-Id: I28c7e951211c9cf6bd5e35d8dfaf57f22e843ed0
@Augustin-Zidek
Copy link
Collaborator

Fixed in 1d43aaf.

eriksf pushed a commit to TACC/alphafold that referenced this issue Oct 7, 2021
@Augustin-Zidek @eriksf
Accept any ordering given by ListDir in the assert.
d6acf04 
Addresses google-deepmind#168.

PiperOrigin-RevId: 395907797
Change-Id: I28c7e951211c9cf6bd5e35d8dfaf57f22e843ed0
@rigan0707
Copy link

Hi,

I tried to run run_alphafold_test.py, and I think the line79-82, i.e., self.assertSequenceEqual( ['features.pkl', 'msas', 'ranked_0.pdb', 'ranking_debug.json', 'relaxed_model1.pdb', 'result_model1.pkl', 'timings.json', 'unrelaxed_model1.pdb'], target_output_files)

should be self.assertSequenceEqual( sorted(['features.pkl', 'msas', 'ranked_0.pdb', 'ranking_debug.json', 'relaxed_model1.pdb', 'result_model1.pkl', 'timings.json', 'unrelaxed_model1.pdb']), sorted(target_output_files))

dogrecajb added a commit to dogrecajb/alphafold that referenced this issue Jul 4, 2024
@dogrecajb @copybara-github
Accept any ordering given by ListDir in the assert.
bbeda6a 
Addresses google-deepmind/alphafold#168.

PiperOrigin-RevId: 395907797
Change-Id: I28c7e951211c9cf6bd5e35d8dfaf57f22e843ed0
ploegieku added a commit to ploegieku/alphafold that referenced this issue Aug 6, 2024
@ploegieku @copybara-github
Accept any ordering given by ListDir in the assert.
322fa39 
Addresses google-deepmind/alphafold#168.

PiperOrigin-RevId: 395907797
Change-Id: I28c7e951211c9cf6bd5e35d8dfaf57f22e843ed0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Augustin-Zidek @player1321 @rigan0707