Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike add password change decoration for authentication token renewal #47

Open
wants to merge 7 commits into
base: fix-authentication-token-not-renewed-after-password-change
Choose a base branch
from
Open

Spike add password change decoration for authentication token renewal #47

wants to merge 7 commits into from

Conversation

gonzalo-bulnes
Copy link
Owner

As a developer
In order to get an insight of which way could lead to effectively decorating the Devise::PasswordsController#update action
And to be able to decide which is the better way to write the corresponding RSpec example
I want to explore some of the possible implementations

This spike is part of #40.

@gonzalo-bulnes
Add Rails engine behaviour
f1a0114
@gonzalo-bulnes
Add Rails Engine Decorators
0b41ba3 
See https://github.com/atd/rails_engine_decorators
@gonzalo-bulnes
Add Rails Engine Decorators explicit requirement
1f1ece4 
Many thanks @atd!
atd/rails_engine_decorators#6 (comment)
@gonzalo-bulnes
Minor add comments about roadmap
9c7c9f9 
Minor fix RSpec expectation
Minor fix Cucumber step misspelling
@gonzalo-bulnes
Temporary mark integration test as pending
7a07d2b 
Marking this integration test as pending increses the visibility
of the ActsAsTokenAuthenticatable#renew_authentication_token! unit tests.

This commit must be reverted once the test suite is green again.
@gonzalo-bulnes
Copy link
Owner Author

Relevant Devise code:

@gonzalo-bulnes gonzalo-bulnes force-pushed the fix-authentication-token-not-renewed-after-password-change branch from 1f1ece4 to 998c5d0 Compare August 27, 2014 15:51
@gonzalo-bulnes gonzalo-bulnes mentioned this pull request Jun 25, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gonzalo-bulnes