Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cassandra and Cequel. Resolves #315 #318

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blazczak
Copy link

Adds support for simple_token_authentication when dealing with Cequel::Record(s).

count() could cause a full scan of table on Cassandra and thus Cequel throws DangerousQueryError. find_by_authentication_token() uses the already present index.

@gonzalo-bulnes
Copy link
Owner

Hi @blazczak!

Thank you for your PR! I've skimmed through and it looks all right, I'll check what else should go in the next release (I've a few things pending) and let you know when I release it : )
(I'll likely make it v1.16.0, but I'll let you know.)

@blazczak
Copy link
Author

Hey @gonzalo-bulnes, I was glad to help.

I just came across this, I see v1.17.0 has been out. Let me know if anything else is needed for this.

@gonzalo-bulnes gonzalo-bulnes added the new feature This pull request adds a new feature. label Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This pull request adds a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants