fix: typecheck issues should never be ignored

golangci · Jul 10, 2024 · 191b8d0 · 191b8d0
1 parent ee37ef3
commit 191b8d0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/pkg/result/processors/autogenerated_exclude.go b/pkg/result/processors/autogenerated_exclude.go
@@ -63,11 +63,6 @@ func (p *AutogeneratedExclude) Process(issues []result.Issue) ([]result.Issue, e
 func (*AutogeneratedExclude) Finish() {}
 
 func (p *AutogeneratedExclude) shouldPassIssue(issue *result.Issue) (bool, error) {
- if issue.FromLinter == typeCheckName {
- // don't hide typechecking errors in generated files: users expect to see why the project isn't compiling
- return true, nil
- }
-
  if filepath.Base(issue.FilePath()) == "go.mod" {
  return true, nil
  }

diff --git a/pkg/result/processors/issues.go b/pkg/result/processors/issues.go
@@ -9,6 +9,12 @@ import (
 func filterIssues(issues []result.Issue, filter func(issue *result.Issue) bool) []result.Issue {
  retIssues := make([]result.Issue, 0, len(issues))
  for i := range issues {
+ if issues[i].FromLinter == typeCheckName {
+ // don't hide typechecking errors in generated files: users expect to see why the project isn't compiling
+ retIssues = append(retIssues, issues[i])
+ continue
+ }
+
  if filter(&issues[i]) {
  retIssues = append(retIssues, issues[i])
  }
@@ -20,6 +26,12 @@ func filterIssues(issues []result.Issue, filter func(issue *result.Issue) bool)
 func filterIssuesErr(issues []result.Issue, filter func(issue *result.Issue) (bool, error)) ([]result.Issue, error) {
  retIssues := make([]result.Issue, 0, len(issues))
  for i := range issues {
+ if issues[i].FromLinter == typeCheckName {
+ // don't hide typechecking errors in generated files: users expect to see why the project isn't compiling
+ retIssues = append(retIssues, issues[i])
+ continue
+ }
+
  ok, err := filter(&issues[i])
  if err != nil {
  return nil, fmt.Errorf("can't filter issue %#v: %w", issues[i], err)