Skip to content

Commit

Permalink
term: enable TestMakeRawState on darwin/arm64
Browse files Browse the repository at this point in the history
Go 1.16 renamed the iOS port from darwin/arm64 to ios/arm64 and
darwin/arm64 was repurposed for the macOS ARM64 port (see
https://golang.org/doc/go1.16#darwin).

Now that Go 1.16 is the oldest supported release, the ios tag can be
used exclusively to detect iOS and TestMakeRawState which ought to run
on darwin/arm64 can be enabled on that platform.

For golang/go#45696

Change-Id: Ic51903ea94def1f1144ca74db37533b5c4de8522
Reviewed-on: https://go-review.googlesource.com/c/term/+/352589
Trust: Tobias Klauser <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
  • Loading branch information
tklauser committed Sep 27, 2021
1 parent 140adaa commit f766a8b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion terminal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ func TestMakeRawState(t *testing.T) {
t.Fatalf("failed to get terminal state from GetState: %s", err)
}

if runtime.GOOS == "ios" || (runtime.GOOS == "darwin" && (runtime.GOARCH == "arm" || runtime.GOARCH == "arm64")) {
if runtime.GOOS == "ios" {
t.Skip("MakeRaw not allowed on iOS; skipping test")
}

Expand Down

0 comments on commit f766a8b

Please sign in to comment.