-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows/svc/mgr: Service.Control: populate Status when returning certain errors #156
Conversation
This PR (HEAD: a4b8c5b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/484895 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Added a test. |
This PR (HEAD: 9859284) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/484895 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 5a7b72a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/484895 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 1c3db80) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/484895 to see it. Tip: You can toggle comments from me using the |
Let's continue conversation in Gerrit https://go-review.googlesource.com/c/sys/+/484895 Alex |
Message from Alex Brainman: Patch Set 6: Run-TryBot+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Gopher Robot: Patch Set 6: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Alex Brainman: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Craig Davison: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Alex Brainman: Patch Set 7: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
This PR (HEAD: 4c0bcbb) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/484895 to see it. Tip: You can toggle comments from me using the |
Message from Craig Davison: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Alex Brainman: Patch Set 8: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Gopher Robot: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Gopher Robot: Patch Set 8: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Alex Brainman: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Gopher Robot: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Gopher Robot: Patch Set 8: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Gopher Robot: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Gopher Robot: Patch Set 8: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Alex Brainman: Patch Set 8: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Gopher Robot: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Gopher Robot: Patch Set 8: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Alex Brainman: Patch Set 8: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Alex Brainman: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Bryan Mills: Patch Set 8: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
This PR (HEAD: 929aeb4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/484895 to see it. Tip: You can toggle comments from me using the |
Message from Craig Davison: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Alex Brainman: Patch Set 9: Code-Review+2 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Gopher Robot: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Gopher Robot: Patch Set 9: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Alex Brainman: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
Message from Dmitri Shuralyov: Patch Set 9: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/484895. |
…ain errors Fixes golang/go#59015 Change-Id: I45f22049f3a05f807f78d20c9ed67c6c79e3d3c1 GitHub-Last-Rev: 929aeb4 GitHub-Pull-Request: #156 Reviewed-on: https://go-review.googlesource.com/c/sys/+/484895 Reviewed-by: Alex Brainman <[email protected]> Run-TryBot: Alex Brainman <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
This PR is being closed because golang.org/cl/484895 has been merged. |
Fixes golang/go#59015