Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make expiryDelta configurable #518

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

cgostuff
Copy link

@cgostuff cgostuff commented Sep 20, 2021

In some use cases, the hardcoded expiryDelta of 10 seconds is too little. Requests can currently be sent when the access token expires anywhere right above 10 seconds, which can result in access tokens expiring before they have the chance to be verified by the recipient - and so the request is discarded. Several people have asked about the possibility of increasing this over the years (issue 249, issue 481, PR 359), so making it configurable would be a nice change I think. This is also a non-intrusive addition that does not affect any existing code or tests.

@google-cla
Copy link

google-cla bot commented Sep 20, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant