Reduce allocations #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made the changes anyway in case you decide it's worth depending on Go 1.3 later. |
|
@bradfitz Now that Go 1.3 has been out for 6 months are you willing to consider moving forward with this PR? |
|
Squash it into one commit and I'll reconsider it. It's too distracting to read as it is. |
|
@ryanslade No problem! |
|
Looks good. Please re-squash. Hey @adg, should we move this to Gerrit too? |
Store temporary buffers in a sync.Pool. Create one httpGetter per peer when Set() is called so we don't allocate a new one on each call PickPeer().
|
@bradfitz Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.