-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reflect: panic on recv channel close #61453
reflect: panic on recv channel close #61453
Conversation
This PR (HEAD: 1414749) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511295. Important tips:
|
Message from Bryan Mills: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
This PR (HEAD: 4feb781) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511295. Important tips:
|
Message from Mauri de Souza Meneguzzo: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
This PR (HEAD: 9ea8b33) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511295. Important tips:
|
Message from Mauri de Souza Meneguzzo: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Ian Lance Taylor: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Gopher Robot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Bryan Mills: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Bryan Mills: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
This PR (HEAD: 1210d48) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511295. Important tips:
|
Message from Mauri de Souza Meneguzzo: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Bryan Mills: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Bryan Mills: Patch Set 5: Code-Review+1 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Gopher Robot: Patch Set 5: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
It is possible to call `reflect.ValueOf(ch).Close()` on a recv-only channel. Following the same semantics as send it should result in a panic. Fixes golang#61445
1210d48
to
2003df3
Compare
Message from Bryan Mills: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
This PR (HEAD: 2003df3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511295. Important tips:
|
Message from Mauri de Souza Meneguzzo: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Ian Lance Taylor: Patch Set 6: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Gopher Robot: Patch Set 6: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Ian Lance Taylor: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
This PR (HEAD: fe2d5e0) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511295. Important tips:
|
Message from Mauri de Souza Meneguzzo: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Ian Lance Taylor: Patch Set 7: Auto-Submit+1 Code-Review+2 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
Message from Gopher Robot: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/511295. |
It is possible to call reflect.ValueOf(ch).Close() on a recv-only channel, while close(ch) is a compile-time error. Following the same reflect semantics as send and recv this should result in a panic. Fixes #61445 Change-Id: I2a9ee8f45963593a37bd6df4643dd64fb322f9f9 GitHub-Last-Rev: fe2d5e0 GitHub-Pull-Request: #61453 Reviewed-on: https://go-review.googlesource.com/c/go/+/511295 Auto-Submit: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
This PR is being closed because golang.org/cl/511295 has been merged. |
It is possible to call reflect.ValueOf(ch).Close() on a recv-only channel,
while close(ch) is a compile-time error. Following the same reflect
semantics as send and recv this should result in a panic.
Fixes #61445