-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: links in summaries have opacity zero #68132
Comments
Bug aside, I would not recommend, in general, putting clickable things in clickable things as it causes accessibility issues. I would recommend removing the links from the summary button, even if this gets fixed. |
@jimmyfrasche You are right. Working on it. |
Currently, links in Readmes are invisible when in the header of a details element. A similar rule exists for the paragraph symbol, but is overwritten by the following block. Remove instructions that make links in summary invisible and remove inactive rule for h2 elements. Fixes golang/go#68132
Change https://go.dev/cl/595055 mentions this issue: |
cc: @jba |
Did some digging: The opacity:0 was added in https://go.dev/cl/304649, presumably to make the anchor links hidden. Then the opacity:0 style for anchor links was rendered obsolete by https://go.dev/cl/520255. So the fix LGTM. |
What is the URL of the page with the issue?
https://pkg.go.dev/github.com/favonia/cloudflare-ddns#readme-migration-guides
What is your user agent?
Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0
Screenshot
What did you do?
Navigate down to the section.
What did you see happen?
Links in
<summary>
are not visible (opacity: 0
in terms of CSS).What did you expect to see?
Links should be visible even within
![image](https://private-user-images.githubusercontent.com/1471328/342005025-e0d6b7bb-9fcb-4e69-aa73-31fbde6a8cf1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMDY5NzcsIm5iZiI6MTcyNjEwNjY3NywicGF0aCI6Ii8xNDcxMzI4LzM0MjAwNTAyNS1lMGQ2YjdiYi05ZmNiLTRlNjktYWE3My0zMWZiZGU2YThjZjEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTJUMDIwNDM3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9M2VlMGE2MGQ2NTUzN2JiMzY3NDYwNGJmMTU1NmMxMzI4NGRlNmE0NGY1ZWM5ZGEzODI3MzViNjlkNzdlZjllYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.xrop5vE2jz9OHP60CCoS5WNlEtmxg9m44aG0MGq_1SM)
<summary>
.The text was updated successfully, but these errors were encountered: