-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/link: runtime.mach_vm_region_trampoline: unsupported dynamic relocation for symbol libc_mach_task_self_ (type=29 (R_GOTPCREL) stype=46 (SDYNIMPORT)) [1.22 backport] #68122
Comments
Only backport to Go 1.22, as the support of dynamic import variable is added in Go 1.22. |
@cherrymui approved. Can you please create a backport for 1.21 as well? |
As commented above #68122 (comment) , I don't think this is necessary (or even possible). Could you explain why this is needed? Thanks. |
Change https://go.dev/cl/595175 mentions this issue: |
@cherrymui it was per a discussion in the meeting today. |
…Darwin in plugin mode CL 501855 added support for cgo_dynamic_import variables on Darwin. But it didn't support the plugin build mode on amd64, where the assembler turns a direct load (R_PCREL) to a load via GOT (R_GOTPCREL). This CL adds the support. We just need to handle external linking mode, as this can only occur in plugin or shared build mode, which requires external linking. Fixes #68122. Updates #67976. Updates #50891. Change-Id: I0f56265d50bfcb36047fa5538ad7a5ec77e7ef96 Reviewed-on: https://go-review.googlesource.com/c/go/+/592499 Reviewed-by: David Chase <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> (cherry picked from commit 44f1870) Reviewed-on: https://go-review.googlesource.com/c/go/+/595175 Reviewed-by: Joedian Reid <[email protected]> Reviewed-by: Than McIntosh <[email protected]>
Closed by merging c2d4f85 to release-branch.go1.22. |
@cherrymui requested issue #67976 to be considered for backport to the next 1.22 minor release.
The text was updated successfully, but these errors were encountered: