Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/test/integration/codelens: TestGCDetails_Toggle/default failures #68110

Closed
gopherbot opened this issue Jun 21, 2024 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestGCDetails_Toggle/default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestGCDetails_Toggle/default
    gcdetails_test.go:52: waiting on:
        Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)" is met, must have:
        any diagnostics for file "main.go", with message containing "42 escapes", with diagnostic "optimizer details" with severity Information and tag []
        
        err:condition has final verdict Unmeetable
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/05/17 10:16:09 Created View (#11)\n\tdirector...
...
[Trace - 10:16:09.894 AM] Received response 'workspace/executeCommand - (3)' in 1ms.
Result: null


[Trace - 10:16:10.486 AM] Received notification '$/progress'.
Params: {"token":"1972677595541516849","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestGCDetails_Toggle/default"
--- FAIL: TestGCDetails_Toggle/default (1.40s)

watchflakes

@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 21, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jun 21, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestGCDetails_Toggle/default"
2024-05-17 17:09 x_tools-go1.22-darwin-amd64_13 tools@de1032b1 release-branch.go1.22@185457da x/tools/gopls/internal/test/integration/codelens.TestGCDetails_Toggle/default (log)
=== RUN   TestGCDetails_Toggle/default
    gcdetails_test.go:52: waiting on:
        Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)" is met, must have:
        any diagnostics for file "main.go", with message containing "42 escapes", with diagnostic "optimizer details" with severity Information and tag []
        
        err:condition has final verdict Unmeetable
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/05/17 10:16:09 Created View (#11)\n\tdirector...
...
[Trace - 10:16:09.894 AM] Received response 'workspace/executeCommand - (3)' in 1ms.
Result: null


[Trace - 10:16:10.486 AM] Received notification '$/progress'.
Params: {"token":"1972677595541516849","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestGCDetails_Toggle/default"
--- FAIL: TestGCDetails_Toggle/default (1.40s)

watchflakes

@findleyr
Copy link
Contributor

Very old flake. Dupe of #67428.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

3 participants