x/tools/gopls/internal/test/integration/codelens: spurious TestGCDetails_Toggle failure

[adonovan]

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test ~ `^TestGCDetails_Toggle/.*`

Observed in one builder in the context of https://go.dev/cl/585277; test passed after re-try.

--- FAIL: TestGCDetails_Toggle/default (2.01s)
    gcdetails_test.go:52: waiting on:
        Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)" is met, must have:
        any diagnostics for file "main.go", with message containing "42 escapes", with diagnostic "optimizer details" with severity Information and tag []
        
        err:condition has final verdict Unmeetable
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/05/16 03:04:39 Created View (#11)\n\tdirector...
        	Info: "2024/05/16 03:04:40 go/packages.Load #27\n\tview_i...
        
        #### diagnostics:
        	main.go (version 1):
        
        #### outstanding work:
        	diagnosing unknown file modification: 0.00
        #### completed work:
        	Checking telemetry prompt: 1
        	diagnosing opened files: 1
        	Toggling GC Details: 1
        	diagnosing initial workspace load: 1
        	Setting up workspace: 1
...

[findleyr]

Attempted to add a watchflakes stanza...

[gopherbot]

Change https://go.dev/cl/586878 mentions this issue: gopls/internal/test/integration: fix race in TestGCDetails_Toggle

[gopherbot]

Sorry, but there were parse errors in the watch flakes script.
The script I found was:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test ~ "^TestGCDetails_Toggle/.*"

And the problems were:

script:2.91: ~ requires backquoted regexp

See https://go.dev/wiki/Watchflakes for details.

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test ~ `^TestGCDetails_Toggle/.*`

2024-05-17 17:09 x_tools-go1.22-darwin-amd64_13 tools@de1032b1 release-branch.go1.22@185457da x/tools/gopls/internal/test/integration/codelens.TestGCDetails_Toggle/default (log)

=== RUN   TestGCDetails_Toggle/default
    gcdetails_test.go:52: waiting on:
        Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)" is met, must have:
        any diagnostics for file "main.go", with message containing "42 escapes", with diagnostic "optimizer details" with severity Information and tag []
        
        err:condition has final verdict Unmeetable
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/05/17 10:16:09 Created View (#11)\n\tdirector...
...
[Trace - 10:16:09.894 AM] Received response 'workspace/executeCommand - (3)' in 1ms.
Result: null


[Trace - 10:16:10.486 AM] Received notification '$/progress'.
Params: {"token":"1972677595541516849","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestGCDetails_Toggle/default"
--- FAIL: TestGCDetails_Toggle/default (1.40s)

— watchflakes