Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/exec: calling Cmd.Start after setting Cmd.Path manually to absolute path without ".exe" no longer implicitly adds ".exe" in Go 1.22 [1.22 backport] #66598

Closed
gopherbot opened this issue Mar 29, 2024 · 3 comments
Closed

os/exec: calling Cmd.Start after setting Cmd.Path manually to absolute path without ".exe" no longer implicitly adds ".exe" in Go 1.22 [1.22 backport] #66598

gopherbot opened this issue Mar 29, 2024 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.22.5

Comments

@gopherbot
Copy link
Contributor

@rsc requested issue #66586 to be considered for backport to the next 1.22 minor release.

@gopherbot please backport go1.22
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 29, 2024
@gopherbot gopherbot mentioned this issue Mar 29, 2024
Closed
@gopherbot gopherbot modified the milestones: Go1.22.2, Go1.22.3 Mar 29, 2024
@gopherbot gopherbot modified the milestones: Go1.22.3, Go1.22.4 May 7, 2024
@gopherbot gopherbot modified the milestones: Go1.22.4, Go1.22.5 Jun 4, 2024
qiulaidongfeng added a commit to qiulaidongfeng/go that referenced this issue Jun 8, 2024
@qiulaidongfeng
[release-branch.go1.22] os/exec: on Windows look for extensions in Ru…
fa7825e 
…n if not already done

CL 512155 fixed golang#36768, but introduced golang#62596.
CL 527820 fixed golang#62596, but meant that the code failed to look up
file extensions on Windows for a relative path.
This CL fixes that problem by recording whether it has already
looked up file extensions.
This does mean that if Path is set manually then we do not update
it with file extensions, as doing that would be racy.

Fixes golang#66598

Change-Id: Id6199945ecca7bbe19d531070eea66b206b0564b
@qiulaidongfeng qiulaidongfeng mentioned this issue Jun 8, 2024
Closed
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/591397 mentions this issue: [release-branch.go1.22] os/exec: on Windows look for extensions in Run if not already done

@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Jun 12, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 12, 2024
@gabyhelp gabyhelp mentioned this issue Jun 18, 2024
Closed
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/594495 mentions this issue: [release-branch.go1.22] os/exec: on Windows look for extensions in Run if not already done

gopherbot pushed a commit that referenced this issue Jun 24, 2024
@qiulaidongfeng @gopherbot
[release-branch.go1.22] os/exec: on Windows look for extensions in Ru…
dfe4dbf 
…n if not already done

CL 512155 fixed #36768, but introduced #62596.
CL 527820 fixed #62596, but meant that the code failed to look up
file extensions on Windows for a relative path.
This CL fixes that problem by recording whether it has already
looked up file extensions.
This does mean that if Path is set manually then we do not update
it with file extensions, as doing that would be racy.

For #66586
Fixes #66598

Change-Id: I9a0305d1e466c5e07bfbe442566ea12f5255a96e
GitHub-Last-Rev: dc3169f
GitHub-Pull-Request: #67035
Reviewed-on: https://go-review.googlesource.com/c/go/+/581695
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
(cherry picked from commit 5532427)
Reviewed-on: https://go-review.googlesource.com/c/go/+/594495
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Commit-Queue: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging dfe4dbf to release-branch.go1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.22.5
Development

No branches or pull requests
2 participants
@prattmic @gopherbot