Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: hash of unhashable type [4]int32 [1.22 backport] #65983

Closed
gopherbot opened this issue Feb 28, 2024 · 9 comments
Closed

cmd/compile: hash of unhashable type [4]int32 [1.22 backport] #65983

gopherbot opened this issue Feb 28, 2024 · 9 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.22.5

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #65957 to be considered for backport to the next 1.22 minor release.

I'm on the fence. We only backport serious issues with no workaround, which I'm not sure this qualifies. It has been a bug since 1.18 and this is the first anyone has reported it. I'm not sure what a workaround might be, though. Does introducing a use of the array type in both packages work as a workaround?

I'll open backports and we can discuss on those issues.

@gopherbot please open backport issues. This issue may warrant backporting. It causes program crashing in some very particular circumstances. (Use of reflect.ArrayOf, and just the right use / nonuse of the corresponding language type in particular packages.)
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 28, 2024
@gopherbot gopherbot mentioned this issue Feb 28, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 28, 2024
@gopherbot gopherbot modified the milestones: Go1.22.1, Go1.22.2 Feb 28, 2024
@thanm
Copy link
Contributor

thanm commented Mar 27, 2024

Discussed during the release checkin meeting. Consensus is that this is not worth back-porting.

@thanm thanm closed this as completed Mar 27, 2024
@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2024
@randall77
Copy link
Contributor

I'm going to reopen for reconsideration. We've received another bug report that we're pretty sure is this issue, #67608.

@randall77 randall77 reopened this Jun 4, 2024
@randall77
Copy link
Contributor

The fix is quite simple and low-risk.

@dmitshur dmitshur modified the milestones: Go1.22.2, Go1.22.5 Jun 5, 2024
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Jun 12, 2024
@prattmic
Copy link
Member

@randall77 Should this have a 1.21 backport as well?

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 12, 2024
@randall77
Copy link
Contributor

There's no known instance of this bug triggering in 1.21. #67608 bisected to https://go-review.googlesource.com/c/go/+/522339 which went out in 1.22.
So I would say, no backport for 1.21.

@joedian
Copy link

joedian commented Jun 24, 2024

@randall77 do we still want to create the cherry pick cl for this?

@randall77
Copy link
Contributor

randall77 commented Jun 24, 2024 •
edited by gabyhelp
Loading

Yes, sorry, just made it at CL 593876.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/593876 mentions this issue: [release-branch.go1.22] cmd/compile: mark pointer to noalg type as noalg

gopherbot pushed a commit that referenced this issue Jun 26, 2024
@wdvxdr1123 @joedian
[release-branch.go1.22] cmd/compile: mark pointer to noalg type as noalg
ceaf26e 
When the compiler writes PtrToThis field of noalg type, it generates
its pointer type. Mark them as noalg to prevent put them in typelinks.

Fixes #65983

Change-Id: Icbc3b18bc866f9138c7648e42dd500a80326f72b
Reviewed-on: https://go-review.googlesource.com/c/go/+/567335
Reviewed-by: Matthew Dempsky <[email protected]>
Auto-Submit: Keith Randall <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
(cherry picked from commit b8c76ef)
Reviewed-on: https://go-review.googlesource.com/c/go/+/593876
Reviewed-by: David Chase <[email protected]>
@dmitshur
Copy link
Contributor

Closed by merging CL 593876 (commit ceaf26e) to release-branch.go1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.22.5
Development

No branches or pull requests
6 participants
@prattmic @dmitshur @randall77 @gopherbot @thanm @joedian