-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/sync/singleflight: add example of using Group #60208
Labels
Documentation
FrozenDueToAge
help wanted
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Comments
cc @bcmills |
heschi
added
help wanted
NeedsFix
The path to resolution is known, but the work has not been done.
labels
May 15, 2023
seankhliao
changed the title
x/sync: add example of using singleflight.Group
x/sync/singleflight: add example of using Group
May 15, 2023
Change https://go.dev/cl/496535 mentions this issue: |
That looks amazing! |
anatoliinzrnk
added a commit
to anatoliinzrnk/go-sync
that referenced
this issue
Sep 25, 2024
Fixes golang/go#60208 Change-Id: I422a45c0f139ba47045f47cec1c96d300a2a424f Reviewed-on: https://go-review.googlesource.com/c/sync/+/496535 Run-TryBot: Bryan Mills <[email protected]> Auto-Submit: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Documentation
FrozenDueToAge
help wanted
NeedsFix
The path to resolution is known, but the work has not been done.
The documentation for singleflightdoesn't show any example of using singleflight.Group.
Thus it's not immediately clear whether the recommended usage is struct or pointer.
(This is not a general discussion/question about the proper use of the library, it's a request for adding documentation for it.)
The text was updated successfully, but these errors were encountered: