Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: include CL 462438 in Go 1.20 #57903

Closed
rsc opened this issue Jan 18, 2023 · 4 comments
Closed

cmd/vet: include CL 462438 in Go 1.20 #57903

rsc opened this issue Jan 18, 2023 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.20

Comments

@rsc
Copy link
Contributor

rsc commented Jan 18, 2023

vet started printing a URL on the end of one of its error messages.
I removed the URL in CL 462438.
The URL was new in Go 1.20 and should be reverted on the release branch.
@rsc
Copy link
Contributor Author

rsc commented Jan 18, 2023

@gopherbot please backport Go 1.20

@gopherbot gopherbot mentioned this issue Jan 18, 2023
Closed
@gopherbot
Copy link
Contributor

Backport issue(s) opened: #57904 (for 1.20).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@findleyr findleyr mentioned this issue Jan 18, 2023
Closed
@cherrymui cherrymui added this to the Go1.20 milestone Jan 18, 2023
@bcmills bcmills mentioned this issue Jan 18, 2023
Closed
@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 18, 2023
@rsc rsc closed this as completed Jan 18, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/462555 mentions this issue: cmd: update x/tools to latest internal Go 1.20 branch

gopherbot pushed a commit that referenced this issue Jan 18, 2023
@rsc @gopherbot
cmd: update x/tools to latest internal Go 1.20 branch
6fcbd03 
Import x/tools as of CL 462596 (070db2996ebe, Jan 18 2022),
to bring in two vet analysis fixes (printf and loopclosure).

For #57911.
Fixes #57903.
Fixes #57904.

Change-Id: I82fe4e9bd56fb8e64394ee8618c155316942a517
Reviewed-on: https://go-review.googlesource.com/c/go/+/462555
Reviewed-by: Bryan Mills <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Auto-Submit: Russ Cox <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/462695 mentions this issue: [release-branch.go1.20] cmd: update x/tools to latest internal Go 1.20 branch

gopherbot pushed a commit that referenced this issue Jan 18, 2023
@rsc @gopherbot
[release-branch.go1.20] cmd: update x/tools to latest internal Go 1.2…
8b34676 
…0 branch

Import x/tools as of CL 462596 (070db2996ebe, Jan 18 2022),
to bring in two vet analysis fixes (printf and loopclosure).

For #57911.
Fixes #57903.
Fixes #57904.

Change-Id: I82fe4e9bd56fb8e64394ee8618c155316942a517
Reviewed-on: https://go-review.googlesource.com/c/go/+/462555
Reviewed-by: Bryan Mills <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Auto-Submit: Russ Cox <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-on: https://go-review.googlesource.com/c/go/+/462695
Run-TryBot: Russ Cox <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
@golang golang locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
3 participants
@rsc @gopherbot @cherrymui