Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use short token for code highlighting #5350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stephenfin
Copy link

@stephenfin stephenfin commented Oct 24, 2018

Closes: #5349

As noted in #5349, rst2html can generate HTML with short or long form class names for syntax highlighting. Pygments (via the pygmentize command) seems to generate short form by default without any way to switch this. This means most/any stylesheets for code provided with various themes won't work when using rST output. This can easily be fixed by providing the --syntax-highlight=short flag to rst2html.

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Author

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Looks like something's off here

@bep
Copy link
Member

bep commented Aug 1, 2019

I don't know enough about RsT to merge this. I'm mostly concerned if this new flag will somehow break in some RsT versions.

@anthonyfok any input? others?

@stephenfin
Copy link
Author

I don't know enough about RsT to merge this. I'm mostly concerned if this new flag will somehow break in some RsT versions.

The flag has been present in docutils since at least 0.9.1, which was released in 2012. Ubuntu 16.04 uses 0.12. I think this is pretty safe now.

@alex
Copy link

alex commented May 17, 2020

Looks like there's now a merge conflict because the location of this code changed. If I were to rebase this PR, would that be somethign that could merged, or are there larger concerns?

@stephenfin
Copy link
Author

I've rebased this. It's definitely safe

@stale
Copy link

stale bot commented Aug 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Aug 16, 2020
@stephenfin
Copy link
Author

This is still valid. Let me know if I can help explain anything

@stale stale bot removed the Stale label Aug 16, 2020
@bep bep added this to the v0.75 milestone Aug 16, 2020
@bep bep added the Keep label Aug 16, 2020
@bep bep modified the milestones: v0.75, v0.76 Sep 14, 2020
@sumnerevans
Copy link

@stephenfin looks like there's a merge conflict to resolve here.

@bep bep modified the milestones: v0.76, v0.77 Oct 6, 2020
@bep bep modified the milestones: v0.77, v0.78 Oct 30, 2020
@bep
Copy link
Member

bep commented Dec 2, 2020

As I said, I don't know enough about this to review this.

@bep bep modified the milestones: v0.78, v0.83 Apr 23, 2021
@bep bep modified the milestones: v0.83, v0.84 May 1, 2021
@bep bep added this to the v0.118.0 milestone Aug 30, 2023
@bep bep modified the milestones: v0.118.0, v0.119.0 Sep 15, 2023
@bep bep modified the milestones: v0.119.0, v0.120.0 Oct 4, 2023
@bep bep modified the milestones: v0.120.0, v0.121.0 Oct 31, 2023
@bep bep modified the milestones: v0.121.0, v0.122.0 Dec 6, 2023
@bep bep modified the milestones: v0.122.0, v0.123.0, v0.124.0 Jan 27, 2024
@bep bep modified the milestones: v0.124.0, v0.125.0 Mar 4, 2024
@bep bep modified the milestones: v0.125.0, v0.126.0 Apr 23, 2024
@bep bep modified the milestones: v0.126.0, v0.127.0 May 15, 2024
@bep bep modified the milestones: v0.127.0, v0.128.0 Jun 8, 2024
@bep bep modified the milestones: v0.128.0, v0.129.0 Jun 21, 2024
@bep bep modified the milestones: v0.129.0, v0.131.0 Jul 22, 2024
@bep bep modified the milestones: v0.131.0, v0.133.0 Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

reStructuredText uses long token names for syntax highlighting
6 participants