commands: Added new option cleanDestinationDirKeepDotFolder
#3210
Conversation
Add a new option to ignore 'dot' folders when deleting files in destination dir. Fixes gohugoio#3208
|
relates to: #3202 |
commands/hugo.go
Outdated
|
|
||
| if c.Cfg.GetBool("cleanDestinationDirKeepDotFolders") { | ||
| syncer.DeleteFilter = func(f os.FileInfo) bool { | ||
| return f.IsDir() && len(f.Name()) > 0 && string(f.Name()[0]) == "." |
There was a problem hiding this comment.
Use strings.HasPrefix(f.Name(), ".")
| @@ -21,37 +21,38 @@ hugo benchmark | |||
| ### Options | |||
|
|
|||
| ``` | |||
There was a problem hiding this comment.
All doc below /commands is autogenerated so no need to edit it by hand.
commands/hugo.go
Outdated
| @@ -578,9 +580,16 @@ func (c *commandeer) copyStatic() error { | |||
| syncer.DestFs = c.Fs.Destination | |||
| // Now that we are using a unionFs for the static directories | |||
| // We can effectively clean the publishDir on initial sync | |||
| syncer.Delete = c.Cfg.GetBool("cleanDestinationDir") | |||
| syncer.Delete = c.Cfg.GetBool("cleanDestinationDir") || c.Cfg.GetBool("cleanDestinationDirKeepDotFolders") | |||
There was a problem hiding this comment.
We have enough flag.
I would say that having a cleanDestinationDir command that also deleted hidden folders ("." files) was a surprise for many. So I suggest we just make this the new default and make sure to document it. People who want to remove the entire folder can use rm -rf.
There was a problem hiding this comment.
No problem, I'm not sure where to update the documentation, do I just update commands/hugo.go?
ln:215:
cmd.Flags().Bool("cleanDestinationDir", false, "Remove files from destination not found in static directories. Folders beginning with "." are ignored")
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Add a new option to ignore 'dot' folders when deleting files in destination dir.
Fixes #3208