Add support for sort by boolean

gohugoio · May 2, 2020 · 04b1a6d · 04b1a6d
1 parent dd31e80
commit 04b1a6d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/tpl/collections/sort_test.go b/tpl/collections/sort_test.go
@@ -218,6 +218,9 @@ func TestSort(t *testing.T) {
  map[interface{}]interface{}{"Title": "Foo", "Weight": 10},
  },
  },
+ // test boolean values
+ {[]bool{false, true, false}, "value", "asc", []bool{false, false, true}},
+ {[]bool{false, true, false}, "value", "desc", []bool{true, false, false}},
  // test error cases
  {(*[]TstX)(nil), nil, "asc", false},
  {TstX{A: "a", B: "b"}, nil, "asc", false},

diff --git a/tpl/compare/compare.go b/tpl/compare/compare.go
@@ -252,6 +252,11 @@ func (ns *Namespace) compareGet(a interface{}, b interface{}) (float64, float64)
  case timeType:
  left = float64(toTimeUnix(av))
  }
+ case reflect.Bool:
+ left = 0
+ if av.Bool() {
+ left = 1
+ }
  }
 
  bv := reflect.ValueOf(b)
@@ -275,6 +280,11 @@ func (ns *Namespace) compareGet(a interface{}, b interface{}) (float64, float64)
  case timeType:
  right = float64(toTimeUnix(bv))
  }
+ case reflect.Bool:
+ right = 0
+ if bv.Bool() {
+ right = 1
+ }
  }
 
  if ns.caseInsensitive && leftStr != nil && rightStr != nil {