Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add permission api #19543

Merged
merged 2 commits into from
Nov 9, 2023
Merged

add permission api #19543

merged 2 commits into from
Nov 9, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Nov 6, 2023

The permission api targets to return the full set of permissons for robot to use. And only system and project admin have the access

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #19543 (6eacb53) into main (da949bf) will decrease coverage by 3.14%.
The diff coverage is 3.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19543      +/-   ##
==========================================
- Coverage   70.64%   67.51%   -3.14%     
==========================================
  Files         745      989     +244     
  Lines       95438   109034   +13596     
  Branches        0     2737    +2737     
==========================================
+ Hits        67419    73609    +6190     
- Misses      24353    31457    +7104     
- Partials     3666     3968     +302     
Flag Coverage Δ
unittests 67.51% <3.61%> (-3.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/server/v2.0/handler/handler.go 0.00% <0.00%> (ø)
src/pkg/cached/project/redis/manager.go 55.69% <0.00%> (-1.45%) ⬇️
src/pkg/project/manager.go 5.26% <0.00%> (-0.30%) ⬇️
src/controller/member/controller.go 21.15% <50.00%> (+1.15%) ⬆️
src/pkg/project/dao/dao.go 63.77% <0.00%> (-7.28%) ⬇️
src/server/v2.0/handler/permissions.go 0.00% <0.00%> (ø)

... and 249 files with indirect coverage changes

The permission api targets to return the full set of permissons for robot to use.
And only system and project admin have the access

Signed-off-by: wang yan <[email protected]>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants