Remove call to set GOMAXPROCS #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Martchus
pushed a commit
to Martchus/gogs
that referenced
this pull request
Aug 27, 2018
* Partial fix for gogs#4010 Swagger needs a comment line above each swagger:response comment -- it uses these to populate the description: fields. Adding minimal text for now on the way to getting swagger validate to pass. Many standard swagger client libraries will not work at all with gitea until validate passes, so prioritizing that over better descriptions for now. Signed-off-by: Steve Traugott <[email protected]>
Martchus
pushed a commit
to Martchus/gogs
that referenced
this pull request
Aug 27, 2018
* Partial fix for gogs#4010 Swagger needs a description field in each swagger:operation response. Adding minimal text for now on the way to getting swagger validate to pass. Many standard swagger client libraries will not work with gitea until validate passes, so prioritizing that over better descriptions for now. Signed-off-by: Steve Traugott <[email protected]>
Martchus
pushed a commit
to Martchus/gogs
that referenced
this pull request
Aug 27, 2018
* Partial fix for gogs#4010 Swagger validation needs 'required: true' for parameters that are in the URL path. Signed-off-by: Steve Traugott <[email protected]>
Martchus
pushed a commit
to Martchus/gogs
that referenced
this pull request
Aug 27, 2018
Fix all the resting errors to have a valid swagger file. They are still some warnings but nothing blocking. Doing so I found that some request still misses son parameters for some POST/PUT/PATCH request. This means the a client generated from the swagger file will not work completely. Fix gogs#4088 by activating validation in drone Should fix gogs#4010.
Martchus
pushed a commit
to Martchus/gogs
that referenced
this pull request
Aug 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Go 1.5 GOMAXPROCS is already set to the number of CPUs in the system. This call will also be removed from Go in the near future (part of their plans once they feel the scheduler is good enough) so I thought it'd make sense to remove it here.