Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add im7 core GetDelegates() and GetFeatures() #317

Merged
merged 2 commits into from
May 22, 2024

Conversation

coderkun
Copy link

@coderkun coderkun commented May 21, 2024

ImageMagick provides a function to list all registered delegates and a second function to list built-in features. Both are very useful for applications to know the capabilities of ImageMagick and to verify an ImageMagick installation.

This Pull Request adds the function GetDelegates() which returns the output of GetMagickDelegates() and the function GetFeatures() which returns the output of GetMagickFeatures().

imagick/magick_version.go Outdated Show resolved Hide resolved
imagick/magick_version.go Outdated Show resolved Hide resolved
@coderkun
Copy link
Author

@justinfx the tests are failing on Linux but it does not seem related to the changes of the Pull Request. Is there anything that I need to do or is the pipeline not working correctlyb

@justinfx
Copy link
Member

It's a limitation of github actions not being able to use the same env variables in your fork that are set up in the main repo. So the pipeline can pass until it is running on a branch in the main repo. Sucks, but doesn't seem to be another way.

@justinfx justinfx merged commit 6922a51 into gographics:im-7 May 22, 2024
1 of 2 checks passed
@coderkun
Copy link
Author

coderkun commented May 22, 2024

Thanks for merging @justinfx but it looks like the fixup commit did not get squashed into the original commit. Do you want to fix that?

@justinfx
Copy link
Member

It's not a big deal. Already merged at this point. If it were a lot of fixups I would have wanted to squash it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants