Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(os/gsession): add session reset function. fix(i18n/gi18n_manager): TranslateFormat bug fixed #3726

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

lxy1151
Copy link

@lxy1151 lxy1151 commented Aug 14, 2024

session模块:增加了session重置方法。

多语言翻译中TranslateFormat方法增加了动态参数与位置无关的处理(部分翻译在不同语言动态参数位置会变化)。

林孝义 and others added 8 commits July 31, 2024 16:48
@hailaz
Copy link
Member

hailaz commented Aug 15, 2024

session模块:增加了session重置方法。

多语言翻译中TranslateFormat方法增加了动态参数与位置无关的处理(部分翻译在不同语言动态参数位置会变化)。

如果包含两个功能的修改,可以拆分为两个pr提交,这样不会相互影响,也能提高代码审批的效率。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Session module: Added session reset method.

The TranslateFormat method in multi-language translation adds position-independent processing of dynamic parameters (some translations will change the position of dynamic parameters in different languages).

If it contains modifications to two functions, it can be split into two PR submissions, so that they will not affect each other and improve the efficiency of code approval.

林孝义 added 2 commits August 15, 2024 16:59
修改多语言替换和参数无关
还原无关文件
修改多语言替换和参数无关
还原无关文件
处理测试不通过问题
Copy link

sonarcloud bot commented Aug 16, 2024

@lxy1151
Copy link
Author

lxy1151 commented Aug 18, 2024

session模块:增加了session重置方法。
多语言翻译中TranslateFormat方法增加了动态参数与位置无关的处理(部分翻译在不同语言动态参数位置会变化)。

如果包含两个功能的修改,可以拆分为两个pr提交,这样不会相互影响,也能提高代码审批的效率。
好的,下次尽量单一功能提交

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Session module: Added session reset method.
The TranslateFormat method in multi-language translation adds position-independent processing of dynamic parameters (some translations will change the position of dynamic parameters in different languages).

If it contains modifications to two functions, it can be split into two PR submissions, so that they will not affect each other and improve the efficiency of code approval.
Okay, try to submit a single function next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants