Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it returns error when Scan to a none empty slice with empty Result for package gdb #2858

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Aug 10, 2023

No description provided.

frame/g/g_func.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: +0.04% 🎉

Comparison is base (243fe73) 79.17% compared to head (88a4442) 79.22%.
Report is 2 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2858      +/-   ##
==========================================
+ Coverage   79.17%   79.22%   +0.04%     
==========================================
  Files         634      634              
  Lines       52423    52471      +48     
==========================================
+ Hits        41506    41568      +62     
+ Misses       8855     8846       -9     
+ Partials     2062     2057       -5     
Flag Coverage Δ
go-1.18-386 79.30% <62.50%> (+0.05%) ⬆️
go-1.18-amd64 79.32% <62.50%> (+0.10%) ⬆️
go-1.19-386 79.19% <62.50%> (+0.06%) ⬆️
go-1.19-amd64 79.19% <62.50%> (+0.11%) ⬆️
go-1.20-386 79.24% <62.50%> (+0.04%) ⬆️
go-1.20-amd64 79.29% <62.50%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
os/gfpool/gfpool_pool.go 78.37% <ø> (ø)
internal/empty/empty.go 75.73% <53.12%> (+0.92%) ⬆️
database/gdb/gdb_type_result.go 90.83% <100.00%> (+0.48%) ⬆️
frame/g/g_func.go 85.71% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joy999 joy999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没看到有啥问题

@gqcn gqcn merged commit ac3481e into master Aug 17, 2023
18 checks passed
@gqcn gqcn deleted the fix/gdb-error-scan-empty-slice branch August 17, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants