Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interface DB.CheckLocalTypeForField for package gdb #2059

Merged
merged 5 commits into from
Aug 11, 2022

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Aug 9, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #2059 (bc0abcd) into master (95888e0) will decrease coverage by 0.02%.
The diff coverage is 56.60%.

@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
- Coverage   76.50%   76.47%   -0.03%     
==========================================
  Files         518      517       -1     
  Lines       46812    46828      +16     
==========================================
  Hits        35814    35814              
- Misses       9021     9037      +16     
  Partials     1977     1977              
Flag Coverage Δ
go-1.15-386 76.41% <56.60%> (+<0.01%) ⬆️
go-1.15-amd64 76.39% <56.60%> (-0.02%) ⬇️
go-1.16-386 76.38% <56.60%> (-0.03%) ⬇️
go-1.16-amd64 76.38% <56.60%> (-0.03%) ⬇️
go-1.17-386 76.42% <56.60%> (-0.04%) ⬇️
go-1.17-amd64 76.46% <56.60%> (+0.01%) ⬆️
go-1.18-386 76.41% <56.60%> (-0.01%) ⬇️
go-1.18-amd64 76.41% <56.60%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contrib/drivers/pgsql/pgsql.go 61.90% <0.00%> (-4.20%) ⬇️
database/gdb/gdb.go 66.83% <ø> (ø)
database/gdb/gdb_core_structure.go 70.66% <69.76%> (-1.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@houseme houseme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gqcn gqcn merged commit e4c8cfc into master Aug 11, 2022
@gqcn gqcn deleted the feature/improve-gdb branch September 22, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants