Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom tracer url #834

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Support custom tracer url #834

merged 3 commits into from
Jul 11, 2024

Conversation

srijan-27
Copy link
Contributor

@srijan-27 srijan-27 commented Jul 10, 2024 •
edited
Loading

  • Provided support for custom tracer URL, using the config TRACER_URL
  • Deprecated TRACER_HOST and TRACER_PORT

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

aryanmehrotra
aryanmehrotra previously approved these changes Jul 10, 2024
View reviewed changes
ccoVeille
ccoVeille reviewed Jul 10, 2024
View reviewed changes
pkg/gofr/gofr.go Show resolved Hide resolved
pkg/gofr/gofr.go Show resolved Hide resolved
pkg/gofr/gofr.go Show resolved Hide resolved
@aryanmehrotra aryanmehrotra merged commit 2a90407 into development Jul 11, 2024
12 checks passed
@aryanmehrotra aryanmehrotra deleted the custom-tracer-url branch July 11, 2024 07:07
This was referenced Jul 11, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille left review comments

@aryanmehrotra aryanmehrotra aryanmehrotra approved these changes

@vipul-rawat vipul-rawat vipul-rawat approved these changes

@Umang01-hash Umang01-hash Umang01-hash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@srijan-27 @ccoVeille @aryanmehrotra @vipul-rawat @Umang01-hash